Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pure version of separating js and css #204

Merged
merged 1 commit into from
Nov 15, 2023
Merged

feat: pure version of separating js and css #204

merged 1 commit into from
Nov 15, 2023

Conversation

Nomango
Copy link
Contributor

@Nomango Nomango commented Oct 31, 2023 •
edited
Loading

Summary

As discussed in #203, provide a JS bundle without CSS injection and a separate CSS file.

fix #203.

Result

Add two outputs for rollup, generating the following files.

$ tree ./dist                                                          
 ./dist
 ├── medium-zoom.d.ts
 ├── medium-zoom.esm.js
 ├── medium-zoom.js
 ├── medium-zoom.min.js
+└── pure
+   ├── index.d.ts
+   ├── index.js
+   └── style.css

1 directory, 7 files

Usage:

// import pure js files
import mediumZoom from "medium-zoom/dist/pure";

// import pure style files
import "medium-zoom/dist/pure/style.css";

!!!
Tested in Astro only.
!!!

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 54c1f65:

Sandbox Source
@medium-zoom/vanilla-example Configuration
@medium-zoom/vanilla-example Issue #203

@francoischalifour
Copy link
Owner

Thanks so much for handling this @Nomango. I'll review this in the next days.

@francoischalifour francoischalifour changed the base branch from master to pure-bundle November 15, 2023 11:01
@francoischalifour
Copy link
Owner

Changing the base branch to apply further changes to this PR.

@francoischalifour francoischalifour merged commit 70bf0db into francoischalifour:pure-bundle Nov 15, 2023
@francoischalifour francoischalifour mentioned this pull request Nov 15, 2023
Merged
@redvlock redvlock mentioned this pull request May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoischalifour francoischalifour francoischalifour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not working after the page transition in Astro
2 participants
@Nomango @francoischalifour